MicroShed/microshed-testing

Create TomEE adapter module

Open

#105 opened on Nov 11, 2019

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)Java (25 forks)auto 404
good first issueis:enhancement

Repository metrics

Stars
 (68 stars)
PR merge metrics
 (PR metrics pending)

Description

Describe the solution you'd like Currently the OpenLiberty and Payara runtimes have dedicated modules that provide some helpful default configuration like:

  • default ports
  • default dockerfile instructions

It would be nice if TomEE also had a default module so users are not required to have a Dockerfile

Describe alternatives you've considered It is still possible to use MicroShed Testing on a TomEE app without a dedicated TomEE adapter module, but this relies on:

  • Inspecting the docker container for exposed port on each run (adds about a second to the test runtime)
  • the user having a Dockerfile in their repo (if building the app from source)

Additional context Write an adapter involves implementing the org.microshed.testing.testcontainers.spi.ServerAdapter interface in a new module. See the Payara micro adapter for a minimal example

Contributor guide

Research direction
Study the existing Payara Micro adapter module in the microshed testing project to understand how ServerAdapter is implemented. Review the ServerAdapter interface and the module's pom.xml to see how dependencies are defined. Then create a new TomEE adapter module with similar default configuration for ports and Dockerfile. Follow the same package structure and ensure tests pass.
Tech stack
java
Domain
backendtesting
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
JavaMavenGitDocker
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75