Meteor-Community-Packages/meteor-roles

Internal function _getInheritedRoleNames() should return role object

Open

#304 opened on Dec 10, 2019

View on GitHub
 (0 comments) (0 reactions) (0 assignees)JavaScript (919 stars) (161 forks)batch import
enhancementgood first issue

Description

https://github.com/Meteor-Community-Packages/meteor-roles/blob/32c230ded9cb92b27a3485d143cabf2732fef186/roles/roles_common.js#L543-L557

The function _getInheritedRoleNames() is currently used to construct the array inheritedRoles on a role-assignment, where it only takes over the parameter _id. If you have data stored on the role, wouldn't it be better to have it copied along?

If one of these parameter changes, the programmer extending this package would then be responsible for also keeping this data updated there. If he doesn't need it there, he can extend this package wrapping this function to remove the additional properties.

Contributor guide

Tech stack
javascriptnodejsmongodb
Domain
authorization
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
JavaScriptMeteor
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Examine the ` getInheritedRoleNames()` function in `roles/roles common.js` (lines 543–557). Understand how it currently returns only role names and how the `inheritedRoles` array is constructed. Consider modifying the function to return the full role object so that additional properties are preserved. Evaluate the impact on callers and ensure backward compatibility or provide an option.