Meteor-Community-Packages/meteor-roles

Migration Script should delete old roles

Open

#300 opened on Nov 28, 2019

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (919 stars) (161 forks)batch import
help wantedv1

Description

The migration scripts do not delete the old roles in the Roles collection:

{ "_id" : "admin", "children" : [ ] } //new role is created
{ "_id" : "u9jJZoAfaEApp6QBw", "name" : "admin" } // old role is still here

Shouldn't the old roles go the way of the dodo?

Contributor guide

Tech stack
javascript
Domain
backenddatabase
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
MeteorMongoDBmigration patterns
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
The issue points out that migration scripts in the meteor roles package do not delete old role documents, leaving duplicates. To fix, locate the migration script files (likely in a 'migrations' or 'server' directory), add logic to remove documents from the Roles collection that have an 'name' field matching the new role's name, or use a unique constraint. Check existing PRs or comments for more context, and ensure backward compatibility.