Meteor-Community-Packages/meteor-roles

[v2.0] support onlyAssigned option for method getUsersInRole

Open

#177 opened on Feb 1, 2016

View on GitHub
 (3 comments) (0 reactions) (0 assignees)JavaScript (919 stars) (161 forks)batch import
enhancementgood first issuehelp wanted

Description

Use case In my model, 'project.member' is a sub-role of 'project.manager'. If I want a list of all project members that are not managers, AFAIK I cannot yet. Well yes, I can filter the output of getUsersInRole but that's not convenient.

Solution The method getRolesForUser already support this option :

onlyAssigned: return only assigned roles and not automatically inferred (like subroles)

So basically, the idea is to filter users which role param has an assigned:true field, perhaps using Roles._onlyAssignedMatcher method.

Contributor guide

Tech stack
javascript
Domain
authorization
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
familiarity with Meteor roles package
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Check the implementation of `getRolesForUser` to see how the `onlyAssigned` option is handled, especially the use of `Roles. onlyAssignedMatcher`. Apply a similar pattern to `getUsersInRole` method in the same source file. Also update relevant tests to cover the new option.