[Bug]: Deploying a failing contract turns into a success Contract Deployment event

Open
#172 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
blockchain, frontend

Research direction

Start in the Test Dapp deployment flow and reproduce the listed steps with the Deploy Failing contract action. Check the Transaction activity tab and trace how the deployment result is displayed; done means a failed deployment shows an error marked "Failed" rather than "Contract is deployed successfully."

Written by the indexing model from the issue text.

Description

Problem: when I click on Deploy a failing contract, I'm expecting to see an error on the transaction log, but I see that Contract is deployed successfully (apparently).

https://user-images.githubusercontent.com/54408225/172138654-c3590c7c-8816-497b-978e-00b6d6082eda.mp4

Expectation: we should see an error saying "Failed" on the contract log transaction, like in the case below

https://user-images.githubusercontent.com/54408225/172138693-fa86ab56-3dfe-4bd8-9834-9708fa9ab536.mp4

Steps:

  1. Go to Test Dapp
  2. Connect Metamask
  3. Click Deploy Failing contract
  4. Check Transaction activity tab
Dominant language
JavaScript
Stars
642
Forks
369
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from MetaMask/test-dapp

All issues in MetaMask/test-dapp

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.