v3 signature challenge does not match the defined type

Open
#130 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript
Domain
cryptography

Research direction

Start at src/index.js around line 801 and inspect the v3 signature challenge alongside the signer's validation and its defined type. Confirm where the mismatch is represented and verify that the challenge and type are consistent, using any existing validation or end-to-end checks you find.

Written by the indexing model from the issue text.

Description

This should be caught in our signer's validation, but we could at least be consistent here:
https://github.com/MetaMask/test-dapp/blob/main/src/index.js#L801

Dominant language
JavaScript
Stars
642
Forks
369
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from MetaMask/test-dapp

All issues in MetaMask/test-dapp

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.