MetaMaskOnboarding
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 35/100
- Issue type
- Bug
- Clarity
- Mostly clear
- Activity status
- Stale
- Tech stack
- javascript
- Domain
- frontend
Research direction
Start at line 184 and inspect isMetaMaskInstalled() together with updateButtons and its onboarding branches. Verify the undefined result follows the intended not-installed path, showing the install prompt rather than the connected state, and confirm the account buttons remain disabled.
Written by the indexing model from the issue text.
Description
At line 184 isMetamaskInstalled() will return undefined so turning it into a false positive will go for Onboarding
const updateButtons = () => {
const accountButtonsDisabled = !isMetaMaskInstalled() || !isMetaMaskConnected()
if (accountButtonsDisabled) {
for (const button of accountButtons) {
button.disabled = true
}
clearTextDisplays()
} else {
deployButton.disabled = false
sendButton.disabled = false
createToken.disabled = false
personalSign.disabled = false
signTypedData.disabled = false
getEncryptionKeyButton.disabled = false
ethSign.disabled = false
personalSign.disabled = false
signTypedData.disabled = false
signTypedDataV3.disabled = false
signTypedDataV4.disabled = false
}
if (!isMetaMaskInstalled()) {
addEthereumChain.disabled = true
onboardButton.innerText = 'Click here to install MetaMask!'
onboardButton.onclick = onClickInstall
onboardButton.disabled = false
} else if (isMetaMaskConnected()) {
addEthereumChain.disabled = false
onboardButton.innerText = 'Connected'
onboardButton.disabled = true
if (onboarding) {
onboarding.stopOnboarding()
}
} else {
addEthereumChain.disabled = true
onboardButton.innerText = 'Connect'
onboardButton.onclick = onClickConnect
onboardButton.disabled = false
}
}
- Dominant language
- JavaScript
- Stars
- 642
- Forks
- 369
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from MetaMask/test-dapp
-
vvxg66w6tx Open
Difficulty 5/5 Over a week Newbie friendliness 1/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 35/100
-
Difficulty 3/5 1-2 days Newbie friendliness 20/100
-
Add EIP-7702 example Open
Difficulty 4/5 3-5 days Newbie friendliness 25/100
-
team-wallet-framework wf-project-standardization
Difficulty 4/5 3-5 days Newbie friendliness 42/100
All issues in MetaMask/test-dapp
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
HarperFast/skills#96 ·
-
[Block] Latest Posts [Type] Bug
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Automattic/studio#4908 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
sugarlabs/musicblocks#8847 ·