`package.json` synchronizer assumes that all dependency version strings use a leading character

Open
#24 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
58/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
typescript
Domain
tooling

Research direction

Start at src/processing/package-json.ts, especially line 64, and inspect how dependency version strings are handled during synchronization. Reproduce the crash with an unprefixed version such as 2.26.0, then verify that synchronization succeeds for unprefixed versions while existing ^ and ~ versions continue to work.

Written by the indexing model from the issue text.

Description

bug team-wallet-framework wf-bugs

If the version string for one of the dependencies in your package is, say, 2.26.0 instead of ^2.26.0, then the tool will crash when attempting to sync the dependencies.

See this line: https://github.com/MetaMask/template-sync/blob/294727e368f1120e79c29fa4039b2fcf49c95bb1/src/processing/package-json.ts#L64. I think we only need to take off the leading character if it is ^ or ~.

Dominant language
TypeScript
Stars
7
Forks
3
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from MetaMask/template-sync

All issues in MetaMask/template-sync

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.