Investigate disabled rules after ESLint 9 migration

Open
#3,132 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
eslint, typescript
Domain
tooling

Research direction

Start by locating the lint-violation comments added during the ESLint 9 migration and review the disabled rules around them. For each case, determine whether the violation can be fixed; done means the violation is fixed or the reason for keeping it disabled is documented.

Written by the indexing model from the issue text.

Description

snaps-refined-backlog

Some lint violations were disabled after the migration. In those cases I added a comment "Either fix this lint violation or explain why it's necessary to ignore.". We should follow up on these and investigate further if we can fix these somehow.

Dominant language
TypeScript
Stars
853
Forks
662
Avg merge
2d 8h
Merged PRs (30d)
8

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from MetaMask/snaps

All issues in MetaMask/snaps

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.