Display different warning for fuzzylist matches (i.e. suspected imitation websites)

Open
#37 0 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
42/100
Issue type
Feature
Clarity
Needs clarification
Activity status
Stale
Tech stack
typescript
Domain
security

Research direction

No files, tests, or entry points are named. Start by locating the warning-rendering path and where fuzzylist matches are distinguished from malicious-site matches; done means fuzzylist matches receive a separate cautionary warning without changing the malicious-site warning.

Written by the indexing model from the issue text.

Description

enhancement

Currently we have a list of malicious sites that we check against, and a list of sites that are at risk of being imitated (the "fuzzylist"). But we show the same warning for both. Most of the complaints we get in eth-phishing-detect about wrongly-blocked sites are due to the fuzzylist blocking something that clearly isn't an imitator, it just has a similar name.

We could show a different warning for the fuzzylist matches. Instead of saying the site is malicious, we could tell the user that it looks like it might be a ____ imitator, and if so to not trust it. Maybe warrants more of a "cautionary" warning in general.

Dominant language
TypeScript
Stars
20
Forks
17
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from MetaMask/phishing-warning

All issues in MetaMask/phishing-warning

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.