MetaMask/metamask-extension

Replace deprecated Menu component with Popover from the component-library

Open

#20498 opened on Aug 17, 2023

View on GitHub
 (32 comments) (0 reactions) (0 assignees)JavaScript (11,014 stars) (4,848 forks)batch import
good first issueteam-design-system

Description

Description

Currently, the extension is using an outdated Menu component, which needs to be replaced with the new Popover component.

This is a massive undertaking by itself and creating a single PR would be too large. Smaller PRs can be submitted against this issue to ensure easier review and gradual improvements.

Technical Details

  • Replace instances of Menu component (ui/components/ui/menu/menu.js) with Popover component (ui/components/component-library/popover/popover.tsx)
  • Component APIs are slightly different so ensure all props have been migrated appropriately

Acceptance Criteria

  • Instances of Menu component are completely replaced with the new Popover component
  • The component APIs are updated to reflect the changes in the new Popover component and there is no functional changes or visual regression
  • Each Pull Request (PR) should include no more than 3 files
  • The code changes should pass Jest tests, linting, and Storybook without any errors.
  • The PR must include before and after screenshots of the UI to ensure there are no visual regressions.

If the acceptance criteria is not met, PRs may be closed.

Difficulty: Intermediate

Good first issue for: External contributors who are familiar with running the extension locally, have knowledge of React, component props, Jest tests, linting, and Storybook, and want to contribute to improving the cohesiveness of UI in the extension

Contributor guide

Tech stack
javascriptreactjeststorybook
Domain
frontend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
over 1 week
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
ReactJestStorybookrunning MetaMask extension locally
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate the existing usage of the Menu component in files like ui/components/ui/menu/menu.js. Compare the API of the Popover component in ui/components/component library/popover/popover.tsx and identify differences in props. Then, create a small PR replacing up to 3 files with the new component while ensuring all tests (Jest, linting, Storybook) pass. Review comments on the issue for any ongoing discussion or guidance from maintainers.