[bitcoin-wallet-snap] Add support for `keyring_createAccounts`
Nobody has claimed this yet.
Assessment
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Newbie friendliness
- 48/100
- Issue type
- Feature
- Clarity
- Mostly clear
- Activity status
- Quiet
- Tech stack
- typescript
Research direction
Start with the Bitcoin snap's existing keyring methods and the linked keyring_createAccounts signature, then compare the Solana snap PR. Inspect controller-init/multichain/multichain-account-service-init.ts for the extension client and locate the corresponding configuration for the other client. Done means the Bitcoin snap supports the method, a new version is released, and both clients enable batched account creation.
Written by the indexing model from the issue text.
Description
Description
As part of the performance improvements around account management, the keyring API now supports a new method to allow the creation of multiple accounts in one request via the method keyring_createAccounts (@metamask/keyring-api version 22.0.0), this new RPC method accepts a batch request — either a single BIP-44 index or an inclusive index range — and creates all accounts in one call.
This ticket requires the Bitcoin snap to also support the method keyring_createAccounts and update the clients configuration to enable account creation batching. To do so, go to the file controller-init/multichain/multichain-account-service-init.ts (extension client case) and update the Bitcoin provider configuration to set createAccounts > batched to true
Acceptance Criteria
- The Bitcoin snap now supports
keyring_createAccounts - A new version is released and both clients are updated to use it
- Set the
createAccounts > batchedconfiguration value totruein both clients
References
- Dominant language
- TypeScript
- Stars
- 1
- Forks
- 2
- Avg merge
- 1d 21h
- Merged PRs (30d)
- 105
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from MetaMask/internal-snaps
-
MetaMask/internal-snaps#64 · 3 comments · 1 assignee ·
-
bug
Difficulty 3/5 1-2 days Newbie friendliness 48/100
MetaMask/internal-snaps#65 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
MetaMask/internal-snaps#111 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
MetaMask/internal-snaps#66 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 45/100
MetaMask/internal-snaps#30 ·
All issues in MetaMask/internal-snaps
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
copse-dev/agent-pane#2953 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 84/100
Eynzof/Hermes-CN-Desktop#610 ·
-
bug clawsweeper:linked-pr-open clawsweeper:needs-live-repro clawsweeper:no-new-fix-pr impact:message-loss issue-rating: 🐚 platinum hermit P2 regression
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 68/100
-
calcite-components needs triage refactor
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
Esri/calcite-design-system#15203 ·