`changelog-check` seems to mistakenly perceive changes to package scripts as needing changelog entries

Open
#152 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
55/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
typescript
Domain
ci-cd, tooling

Research direction

Start by tracing the changelog-check workflow and how it classifies package script changes. Verify the behavior for monorepos and, if supported, polyrepos; done means script-only changes no longer require changelog entries while other changes retain the check.

Written by the indexing model from the issue text.

Description

team-core-platform

If you are in a monorepo and you update any of the package scripts, but don't update the changelogs for those packages, the changelog-check workflow will produce an error. (I haven't tested a polyrepo but I suspect the same thing would happen there.)

I don't think this should happen, I think we should exclude changes to scripts.

Dominant language
TypeScript
Stars
12
Forks
7
Avg merge
1d 1h
Merged PRs (30d)
10

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from MetaMask/github-tools

All issues in MetaMask/github-tools

Similar issues

More TypeScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.