Melvin-Abraham/Google-Assistant-Unofficial-Desktop-Client

Shortcut/Hotkey does not work in Wayland sessions on Linux

Open

#46 opened on Nov 30, 2020

View on GitHub
 (1 comment) (0 reactions) (0 assignees)JavaScript (3,511 stars) (407 forks)batch import
good first issue

Description

Describe the bug The super+shift+a hotkey does not work in Wayland sessions.

To Reproduce Steps to reproduce the behavior:

  1. Start a DE in a Wayland session (note: Nvidia cards do not run Wayland)
  2. Verify it is Wayland with echo $XDG_SESSION_TYPE
  3. Attempt to launch the assistant with super+shift+a

Expected behavior Assistant launches

Desktop (please complete the following information):

  • OS: Manjaro Linux (AMD graphics)
  • Version: N/A

Contributor guide

Tech stack
javascriptelectron
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Electron globalShortcut moduleWayland vs X11 differences
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Investigate why Electron's globalShortcut does not work on Wayland. Check if the app uses the globalShortcut module in the main process. Consider using the 'wayland' flag or a native module like 'iohook' or 'uiohook napi' that supports Wayland. Alternatively, leverage xdg desktop portal for global shortcuts. The main process file (likely main.js) should be modified to handle Wayland specific keybinding registration.