Melvin-Abraham/Google-Assistant-Unofficial-Desktop-Client

Switch from grpc to grpc-js

Open

#396 opened on May 25, 2021

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (407 forks)batch import
google-assistant-sdkhelp wanted✨ enhancement

Repository metrics

Stars
 (3,511 stars)
PR merge metrics
 (No merged PRs in 30d)

Description

The gRPC library is deprecated and the app should be switched to gRPC-js. This will help to keep Electron up-to-date making performance and stability better. Since grpc-js is a drop-in replacement, I can create a PR for that if we are interested in this.

Contributor guide

Research direction
Replace the deprecated grpc package with @grpc/grpc js. Update all imports and ensure the client continues to function correctly. Refer to the grpc js documentation for migration steps.
Tech stack
javascriptnodejselectron
Domain
desktopbackend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Node.jsnpm
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85