Melvin-Abraham/Google-Assistant-Unofficial-Desktop-Client

Switch from grpc to grpc-js

Open

#396 opened on May 25, 2021

View on GitHub
 (4 comments) (0 reactions) (0 assignees)JavaScript (3,511 stars) (407 forks)batch import
google-assistant-sdkhelp wanted✨ enhancement

Description

The gRPC library is deprecated and the app should be switched to gRPC-js. This will help to keep Electron up-to-date making performance and stability better. Since grpc-js is a drop-in replacement, I can create a PR for that if we are interested in this.

Contributor guide

Tech stack
javascriptelectronnodejsgrpc
Domain
desktopperformance
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
Node.jsElectrongRPC concepts
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Search for usage of the deprecated `grpc` package in package.json and source files. Identify all imports and client/server code that rely on it. The new `@grpc/grpc js` package is a drop in replacement, so expect minimal API changes. Check for any compatibility notes in the repository's gRPC setup files.