ManimCommunity/manim

Add linting back to CI

Open

#3622 opened on Feb 16, 2024

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Python (17,820 stars) (1,378 forks)batch import
good first issuehelp wantedtracking

Description

Following https://github.com/ManimCommunity/manim/pull/3620, would be great to enforce linting on CI.

I propose using Ruff instead of flake8, it would avoid having to install a bunch of plugins and pyproject.toml configuration is supported.

Format could be included as well if the diff isn't to big.

Contributor guide

Tech stack
python
Domain
ci cd
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
PythonGitHub Actions
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75
Research direction
Refer to PR #3620 for context. The goal is to add a CI step using Ruff for linting. Configuration can be done in pyproject.toml. Check the existing workflow files in .github/workflows for where to add the linting step.