ManimCommunity/manim

Add linting back to CI

Open

#3,622 opened on Feb 16, 2024

View on GitHub
 (5 comments) (0 reactions) (0 assignees)Python (1,378 forks)batch import
good first issuehelp wantedtracking

Repository metrics

Stars
 (17,820 stars)
PR merge metrics
 (Avg merge 90d 10h) (31 merged PRs in 30d)

Description

Following https://github.com/ManimCommunity/manim/pull/3620, would be great to enforce linting on CI.

I propose using Ruff instead of flake8, it would avoid having to install a bunch of plugins and pyproject.toml configuration is supported.

Format could be included as well if the diff isn't to big.

Contributor guide

Research direction
Examine current linting configuration (flake8) and CI setup. Refer to PR #3620 for previous changes. Configure Ruff for linting and optionally formatting, then add a CI job to run it.
Tech stack
python
Domain
ci cd
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70