ManageIQ/miq_bot

A renamed repo causes a stack trace in the GithubNotificationMonitor

Open

#440 opened on Apr 23, 2019

View on GitHub
 (3 comments) (0 reactions) (0 assignees)Ruby (38 forks)auto 404
bughelp wanted

Repository metrics

Stars
 (16 stars)
PR merge metrics
 (PR metrics pending)

Description

I, [2019-04-23T11:36:31.643500 #1449]  INFO -- : Executed GET https://api.github.com/repos/ManageIQ/topological_inventory-ui/notifications?all=false&per_page=100...api calls remaining 349
2019-04-23T15:36:31.650Z 1449 TID-1jxuvg GithubNotificationMonitorWorker JID-9b332b256318047276dd045c ERROR: undefined local variable or method `subject' for [:message, "Moved Permanently"]:GithubService::Notification
2019-04-23T15:36:31.650Z 1449 TID-1jxuvg GithubNotificationMonitorWorker JID-9b332b256318047276dd045c ERROR: /opt/rubies/ruby-2.3.3/lib/ruby/2.3.0/delegate.rb:87:in `method_missing'
/opt/miq_bot/lib/github_service/notification.rb:10:in `issue_number'
/opt/miq_bot/lib/github_notification_monitor.rb:35:in `process_notification'
/opt/miq_bot/lib/github_notification_monitor.rb:24:in `block in process_notifications'
/opt/miq_bot/lib/github_notification_monitor.rb:23:in `each'
/opt/miq_bot/lib/github_notification_monitor.rb:23:in `process_notifications'
/opt/miq_bot/app/workers/github_notification_monitor_worker.rb:23:in `process_repo'
/opt/miq_bot/app/workers/github_notification_monitor_worker.rb:19:in `block in process_repos'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/activerecord-4.2.10/lib/active_record/relation/delegation.rb:46:in `each'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/activerecord-4.2.10/lib/active_record/relation/delegation.rb:46:in `each'
/opt/miq_bot/app/workers/github_notification_monitor_worker.rb:19:in `process_repos'
/opt/miq_bot/app/workers/github_notification_monitor_worker.rb:14:in `perform'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/processor.rb:152:in `execute_job'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/processor.rb:134:in `block (2 levels) in process'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/middleware/chain.rb:128:in `block in invoke'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/sidetiq-0.7.2/lib/sidetiq/middleware/history.rb:18:in `call_with_sidetiq_history'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/sidetiq-0.7.2/lib/sidetiq/middleware/history.rb:6:in `call'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/middleware/chain.rb:130:in `block in invoke'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/middleware/server/active_record.rb:6:in `call'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/middleware/chain.rb:130:in `block in invoke'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/middleware/server/retry_jobs.rb:74:in `call'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/middleware/chain.rb:130:in `block in invoke'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/middleware/server/logging.rb:11:in `block in call'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/logging.rb:32:in `with_context'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/middleware/server/logging.rb:7:in `call'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/middleware/chain.rb:130:in `block in invoke'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/middleware/chain.rb:133:in `invoke'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/processor.rb:129:in `block in process'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/processor.rb:168:in `stats'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/processor.rb:128:in `process'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/processor.rb:80:in `process_one'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/processor.rb:68:in `run'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/util.rb:17:in `watchdog'
/opt/rubies/ruby-2.3.3/lib/ruby/gems/2.3.0/gems/sidekiq-4.1.4/lib/sidekiq/util.rb:25:in `block in safe_thread'
I, [2019-04-23T11:36:31.892500 #1449]  INFO -- : Executed GET https://api.github.com/repos/ManageIQ/topological_inventory-persister/notifications?all=false&per_page=1

Contributor guide

Research direction
Examine the `issue number` method in `notification.rb` and understand how `subject` is expected. The error occurs when a notification lacks a subject, e.g., repo rename. Handle missing subject gracefully.
Tech stack
ruby
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
RubyGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60