ManageIQ/miq_bot

Keep inventory of merged PRs

Open

#363 opened on Oct 5, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Ruby (38 forks)auto 404
enhancementhelp wantedpinned

Repository metrics

Stars
 (16 stars)
PR merge metrics
 (PR metrics pending)

Description

We don't keep an inventory of already merged PRs. The way it works is that we ask GitHub about all of the open PRs, then we just delete the rows for ones that aren't in that query. There are a number of enhancement that would require this to be implemented first.

Opening this issue separate to create a feature dependency tree, but also because I can't think of how to do this in an efficient way. There may also be "partial" implementations, such as instead of deleting from our DB, we just change the status, but this might miss transient PRs that come and go while the bot is down, and we never knew about them in the first place. Additionally, there may be issues for the "first time" the bot sees a repo where it will pull in ALL of the old PRs, but we may not want it to process those.

Contributor guide