ManageIQ/miq_bot

Further GithubService cleanup

Open

#305 opened on Feb 10, 2017

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Ruby (38 forks)auto 404
help wantedpinnedrefactoring

Repository metrics

Stars
 (16 stars)
PR merge metrics
 (PR metrics pending)

Description

(From Gitter convo with @Fryguy)

Now that github_service is complete...can you move GithubUsageTracker underneath it? Thinking something like GithubService::UsageTracker

Also thinking OffenseMessage should move under MessageBuilder (maybe)

Contributor guide

Research direction
Move GithubUsageTracker under GithubService and OffenseMessage under MessageBuilder. Update all references and require statements accordingly.
Tech stack
ruby
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Ruby
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
80