ManageIQ/miq_bot

Complaining about 'pp' in a string

Open

#235 opened on Dec 7, 2016

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Ruby (38 forks)auto 404
bughelp wantedpinned

Repository metrics

Stars
 (16 stars)
PR merge metrics
 (PR metrics pending)

Description

Hi,

if there is 'pp' in a string in an .rb file, the bot complains about debugging statements: screenshot from 2016-12-07 10-05-12

screenshot from 2016-12-07 10-15-23

Contributor guide

Research direction
Inspect the regex that flags debugging statements in the bot and modify it to exclude matches inside string literals.
Tech stack
ruby
Domain
tooling
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
None
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70