ManageIQ/miq_bot

Don't run linters on backport PRs

Open

#206 opened on Jul 5, 2016

View on GitHub
 (1 comment) (0 reactions) (0 assignees)Ruby (38 forks)auto 404
enhancementhelp wantedpinned

Repository metrics

Stars
 (16 stars)
PR merge metrics
 (PR metrics pending)

Description

When backporting it's probably better to keep the code in the same form as the original PR and not make any further changes. As such, we probably want to disable rubocop and haml-lint on PRs to non-master. This may be doable by reusing the branch disablement code.

Contributor guide

Research direction
Find the existing branch disablement code in the repository and extend it to also skip linters (rubocop, haml lint) on PRs targeting non master branches.
Tech stack
ruby
Domain
devopsci cd
Issue type
Feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitRuby
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
65