proxy settings
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 48/100
- Issue type
- Feature
- Clarity
- Clearly specified
- Activity status
- Stale
- Tech stack
- bash, docker
- Domain
- build-system, devops
Research direction
Start with Dockerfile and build.sh, then inspect the existing docker build command and how its build context is assembled. Confirm that proxy settings can be supplied externally during the image build without editing Dockerfile, and verify the image still builds successfully when proxy variables are available.
Written by the indexing model from the issue text.
Description
I had hard times configuring Docker for corporate proxy. It looks like there is just no way to do it externally w.r.t. your Dockerfile, so I had to modify it with the following patch:
diff --git a/Dockerfile b/Dockerfile
index c9a3022..e8a95ef 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -1,6 +1,9 @@
FROM ubuntu:16.04
MAINTAINER elvis@magic.io
-
+ARG http_proxy
+ENV http_proxy=$http_proxy
+ARG https_proxy
+ENV https_proxy=$https_proxy
RUN DEBIAN_FRONTEND=noninteractive \
apt-get update && apt-get install -y \
language-pack-en
diff --git a/build.sh b/build.sh
index 8e128c7..88957b9 100755
--- a/build.sh
+++ b/build.sh
@@ -1,3 +1,3 @@
#!/bin/bash
-docker build -t magic/benchmark $(dirname $0)
+docker build --build-arg http_proxy="$http_proxy" --build-arg https_proxy="$https_proxy" -t magic/benchmark $(dirname $0)
- Dominant language
- Python
- Stars
- 189
- Forks
- 48
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from MagicStack/vmbench
-
Difficulty 2/5 1-3 hours Newbie friendliness 42/100
MagicStack/vmbench#18 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 25/100
MagicStack/vmbench#13 · 1 comment ·
-
Difficulty 5/5 Over a week Newbie friendliness 25/100
MagicStack/vmbench#11 · 1 comment ·
-
Tested versions Open
Difficulty 1/5 Under an hour Newbie friendliness 25/100
MagicStack/vmbench#2 · 3 comments ·
All issues in MagicStack/vmbench
Similar issues
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 70/100
canonical/paas-charm#368 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
tech debt
Difficulty 2/5 1-3 hours Newbie friendliness 75/100
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
StevenBlack/hosts#3256 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 90/100
qualcomm/qai-appbuilder#275 ·