Tiny fix in hton.h

Open
#6 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
1/5
Estimated time
Under an hour
Newbie friendliness
48/100
Issue type
Refactor
Clarity
Clearly specified
Activity status
Stale
Tech stack
c
Domain
backend

Research direction

Open hton.h and inspect the pack_int32 declaration and its callers. Check whether changing the x parameter from int64_t to int32_t is consistent with those uses and preserves the stated result; done means the signature is corrected if appropriate without changing behavior.

Written by the indexing model from the issue text.

Description

Should the argument x here have type int32_t?

pack_int32(char *buf, int64_t x)

I understand that the current version will produce exactly the same result.

Dominant language
Cython
Stars
38
Forks
21
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from MagicStack/py-pgproto

All issues in MagicStack/py-pgproto

Similar issues

More Backend & API Design issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.