Incorrect function highlighting in raw format (rf) string

Open
#267 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
42/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript, python
Domain
tooling

Research direction

Start by reproducing the supplied raw-format string in the supported editor and compare highlighting of the dot, (1), and curly braces. Trace the syntax-highlighting behavior for this example; done means those portions are highlighted consistently with the surrounding Python expression.

Written by the indexing model from the issue text.

Description

I'm getting some incorrect highlighting inside an rf string, in particular for the . and (1) portions, as well as the curly braces. Take a look:

  • Editor name and version: VSCode
  • Platform: Windows
  • Color scheme: Default
  • MagicPython version: v1.1.0
  • A sreenshot:
    image
  • 5-10 lines of surrounding code:
for item in (
    re.split(rf" ?\r <BR> (?=\d+{match.group(1)})", text)
    if (match := re.match(r"1( ?[-.])", text)) is not None
    else [text]
):
Dominant language
JavaScript
Stars
1.4k
Forks
98
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from MagicStack/MagicPython

All issues in MagicStack/MagicPython

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.