MacDownApp/macdown

Handle block quote like list item in editor

Open

#811 opened on May 16, 2017

View on GitHub
 (13 comments) (0 reactions) (0 assignees)Objective-C (7,686 stars) (930 forks)batch import
enhancementhelp wanted

Description

In the editor, if you are editing a list item and you git return, you get a new line that starts with a list item marker. Hit return again without typing further on the live and you get another new line and the item markers disappear.

I like this.

In contrast, if you're in a block quote, new lines will all have the indicator at their starts (>), no matter that the line had nothing in it.

I don't like this and suggest modifying the behavior of the editor in block quotes to match that in lists.

Contributor guide

Tech stack
objective c
Domain
desktop
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Objective CCocoa text system
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Examine the editor's handling of list items when pressing return, likely in a key event handler. Understand how list item markers are removed on empty lines. Apply similar logic to block quote markers. Relevant files may include MPEditor.m or similar. Review comments in the issue for any maintainer pointers.