MacDownApp/macdown

Animated gifs absolutely crush the preview window

Open

#361 opened on May 1, 2015

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Objective-C (7,686 stars) (930 forks)batch import
bughelp wanted

Description

It hangs and draws artifacts all over the place for ~60 seconds after you insert a gif like this one:

slow smile

Maybe this is while the gif is loading? It figures itself out after a while. Sometimes it's like 3 minutes of hang time, actually. Just thought I'd bring it up.

Here is what these artifacts look like:

image

Contributor guide

Tech stack
objective c
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
macOS developmentObjective Cimage processing
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
35
Research direction
Investigate the preview window's image loading mechanism. Look at how animated GIFs are handled, possibly in the rendering code (e.g., in the HTML preview view). Check if there is a missing check for animated GIFs or if image caching is causing the hang. Consider using NSImage or CGImageSource for frame based animation. See related comments in the issue for any hints.