the valid range of A(annotation type value)
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 45/100
Research direction
Start in wfdb/io/annotation.py around the label_store validation at line 563, then review how annotation values above 49 are represented, including the predefined values 59–63. Confirm whether values 49–58 are valid in the WFDB format and update the validation behavior accordingly; done means the restriction matches the format specification.
Written by the indexing model from the issue text.
Description
Why should the value of A be restricted to between 1 and 49? The values greater than 58 are pre-defined as (skip-59, num-60, sub-61, chan-62, aux-63),Can I define the values between 49 and 58(bound included)? and lift this restriction?
https://github.com/MIT-LCP/wfdb-python/blob/main/wfdb/io/annotation.py#L563
elif field == "label_store":
if min(item) < 1 or max(item) > 49:
raise ValueError(
"The label_store values must be between 1 and 49"
)
- Dominant language
- Jupyter Notebook
- Stars
- 853
- Forks
- 322
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from MIT-LCP/wfdb-python
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
MIT-LCP/wfdb-python#568 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 48/100
MIT-LCP/wfdb-python#557 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 58/100
MIT-LCP/wfdb-python#554 ·
-
WFDB path ignored Open
Difficulty 4/5 3-5 days Newbie friendliness 35/100
MIT-LCP/wfdb-python#545 ·
-
Difficulty 5/5 Over a week Newbie friendliness 30/100
MIT-LCP/wfdb-python#540 ·
All issues in MIT-LCP/wfdb-python
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 76/100
run-llama/llama_index#23199 ·
-
enhancement P3: gap query
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
jeffknupp/association#192 ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 88/100
openml/openml-python#1749 ·
-
area:adapters bug engine:v2 snowflake status:triage triage type:bug v2
Difficulty 2/5 1-3 hours Newbie friendliness 72/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 72/100