MISP/MISP

Notice warning when loading warninglists

Open

#6,579 opened on Nov 11, 2020

View on GitHub
 (0 comments) (0 reactions) (0 assignees)PHP (1,306 forks)batch import
S: needs diagnosisT: potential bughelp wantedtopic: warning list

Repository metrics

Stars
 (4,600 stars)
PR merge metrics
 (Avg merge 17d 10h) (50 merged PRs in 30d)

Description

Undefined variable: result [<b>APP/Model/Warninglist.php</b>, line <b>248</b>]

When loading the Event contains one or more entries from the top 500 of the most used domains (Mozilla). list

That's probably because the list is empty: https://github.com/MISP/misp-warninglists/blob/main/lists/moz-top500/list.json

Contributor guide

Research direction
Inspect the code at APP/Model/Warninglist.php line 248 to see where the undefined variable $result comes from, and add a check to handle an empty list gracefully.
Tech stack
php
Domain
backendsecurity
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHP
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
90