MISP/MISP

HTTP 404 when loading logo image on specific deployements

Closed

#1,938 opened on Feb 15, 2017

View on GitHubContributor guide
 (0 comments) (0 reactions) (0 assignees)PHP (1,306 forks)batch import
S: diagnosedS: staleT: potential buggood first issuevisual

Repository metrics

Stars
 (4,600 stars)
PR merge metrics
 (Avg merge 17d 10h) (50 merged PRs in 30d)

Description

Very low impact bug, the logo is not loaded by the browser (404 error). The bug can occur when running the application behind a reverse proxy or under a different URL path like this https://misp.local/misp1.

The default logo path is hardcoded in the file MISP/app/View/Users/login.ctp at the line 22: <img src="/img/misp-logo.png"

It should be loaded dynamically like the custom logos <img src="<?php echo $baseurl?>/img/misp-logo.png"

Contributor guide

Research direction
The issue is in MISP/app/View/Users/login.ctp line 22. The fix is to replace `<img src="/img/misp logo.png">` with `<img src="<?php echo $baseurl?>/img/misp logo.png">`. The variable $baseurl is already used elsewhere in the same file for custom logos. No further investigation needed.
Tech stack
php
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHP basicsBasic understanding of MISP
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
95