LuxDL/Lux.jl

upstream ForwardDiff rules to NNlib.jl

Open

#1,008 opened on Jul 16, 2024

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Julia (700 stars) (84 forks)batch import
good first issueluxlib

Description

Code: https://github.com/LuxDL/LuxLib.jl/blob/3ef59f2e4175dfbbd383ebfb607bea1c8fe60738/src/impl/forward_diff.jl#L1-L50

Tests: https://github.com/LuxDL/LuxLib.jl/blob/main/test/others/forwarddiff_tests.jl

The main reason I haven't been able to do it is because of how the tests are structured which forces you to copy the code for different backends

Contributor guide

Tech stack
None
Domain
machine learning
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
3-5 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
Julia programmingunderstanding of automatic differentiationfamiliarity with LuxLib internals
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
25
Research direction
The main task is to migrate the ForwardDiff rules from LuxLib.jl (specifically src/impl/forward diff.jl) to NNlib.jl, along with corresponding tests from test/others/forwarddiff tests.jl. The issue mentions that test structure currently forces code duplication across backends. To resolve, examine NNlib.jl's existing test patterns and refactor the tests to be backend agnostic. Review the linked files to understand the current implementation, then propose a pull request to NNlib.jl with the moved rules and adapted tests.