Line with just a space in gitignore causes whole project to be ignored
Nobody has claimed this yet.
Assessment
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Newbie friendliness
- 64/100
Research direction
Reproduce the behavior with the Lua.workspace.useGitIgnore setting enabled, a .gitignore containing only a space, and the a.lua assignment described in the issue. Trace the gitignore handling used by diagnostics and verify that a whitespace-only line is ignored without causing the whole project to be ignored.
Written by the indexing model from the issue text.
Description
How are you using the lua-language-server?
Visual Studio Code Extension (sumneko.lua)
Which OS are you using?
Windows
What is the issue affecting?
Diagnostics/Syntax Checking
Expected Behaviour
An empty space (literally just ) along with "Lua.workspace.useGitIgnore" : true being set seems to be causing my whole project to be ignored.
Actual Behaviour
I'd expect it to be ignored. The .gitignore docs (https://git-scm.com/docs/gitignore#_pattern_format) say:
Trailing spaces are ignored unless they are quoted with backslash ("").
Reproduction steps
- Assign global in
a.lua:x = 100 - Add
.gitignorewith empty space character - See below:
Removing the .gitignore file fixes the issue.
Additional Notes
No response
Log File
No response
- Dominant language
- Lua
- Stars
- 4.4k
- Forks
- 442
- Avg merge
- 8d 9h
- Merged PRs (30d)
- 1
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from LuaLS/lua-language-server
-
enhancement
Difficulty 2/5 1-3 hours Newbie friendliness 62/100
LuaLS/lua-language-server#1776 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 65/100
LuaLS/lua-language-server#3463 · 5 comments ·
-
Difficulty 4/5 3-5 days Newbie friendliness 55/100
LuaLS/lua-language-server#3461 ·
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
LuaLS/lua-language-server#3460 · 1 comment · 1 reaction ·
-
Difficulty 3/5 1-2 days Newbie friendliness 68/100
LuaLS/lua-language-server#3459 · 1 reaction ·
All issues in LuaLS/lua-language-server
Similar issues
-
bug
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
mailcow/mailcow-dockerized#7480 ·
-
documentation feature-request mini.completion
Difficulty 1/5 Under an hour Newbie friendliness 88/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 74/100
fluent/fluent-bit-docs#2727 ·
-
OS:Windows
Difficulty 2/5 1-3 hours Newbie friendliness 82/100
-
enhancement needs-triage
Difficulty 2/5 1-3 hours Newbie friendliness 88/100