Empty env. variable prevents the tmux window from being renamed

Open Beginner friendly
#38 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
62/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
python
Domain
cli

Research direction

Start in ssh_manager/tmux.py around lines 13–19 and review commit 7e1c09dc577e804f38d07654abd7e7e7ecf770ae. Reproduce the empty environment-variable case described in the issue and verify that it no longer raises SystemExit before the tmux window can be renamed.

Written by the indexing model from the issue text.

Description

invalid

Definitely a ssh_manager issue

There's a non-zero chance of your issue to pend isn't really related to ssh_manager, so please make sure that:

  1. Re-read the README installation and configuration guide and follow all of those steps
  2. Verify that $servername_user environment that should contain the password for the remote machine exists in your current shell session:
    @ echo $servername_user
    (Where servername and user are matching the entry in ssh_manager storage)
  3. Verify sshpass -p direct connection to remote:
    @ sshpass -p $servername_user ssh user@remoteip
    NOTE that user in $servername_user should be exactly the same as user in ssh user@remoteip
  4. Verify python installation itself:
    @ python3 -V
    OR
    @ python3.x -V where's x is your python release

Checklist:

  • My issue is not related to connection problems, or I'm aware that my ssh_manager storage and shell environment is fine
    • Direct connection using sshpass -p is performed, but connection through ssh_manager seems inappropriate
  • Broken functionality is declared and documented in the README project description

A detailed explanation of the issue goes here

Screenshots, screencasts, and other useful information are welcome

Since https://github.com/LoliPain/ssh_manager/commit/7e1c09dc577e804f38d07654abd7e7e7ecf770ae empty envvar causing SystemExit which prevents graceful re-rename
https://github.com/LoliPain/ssh_manager/blob/db1b9b76f6679f643c8889cc3bd97ef7cdb7307e/ssh_manager/tmux.py#L13-L19

Dominant language
Python
Stars
0
Forks
0
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from LoliPain/ssh_manager

All issues in LoliPain/ssh_manager

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.