Hacktoberfest 2026: the issues maintainers tagged for October, open and beginner-friendly. Browse Hacktoberfest issues

client.Users.GetPersonalBests throws a serialization exception if you use any of the optional parameters

Open
#25 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
45/100
Issue type
Bug
Clarity
Clearly specified
Activity status
Stale
Tech stack
csharp
Domain
api

Research direction

Start in SpeedrunComSharp/Users/UsersClient.cs at UserClient.GetPersonalBests, linked from the issue, and inspect how optional parameters are appended to the request URL. Verify requests with optional parameters produce valid SRC API URLs and no longer turn a 404 response into a serialization exception.

Written by the indexing model from the issue text.

Description

i think it's constructing the URL incorrectly, getting a 404, and then failing to serialize that 404 json into an actual C# object

it looks like the code for UserClient.GetPersonalBests just concatenates the query parameters to the URL string without adding the necessary ? and &s, which doesn't generate a valid URL for the SRC API

Dominant language
C#
Stars
32
Forks
11
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from LiveSplit/SpeedrunComSharp

All issues in LiveSplit/SpeedrunComSharp

Similar issues

More C# issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.