Hidden file affects the position of the icon and cause layout confusion

Open
#237 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
javascript, node.js
Domain
desktop

Research direction

Reproduce the layout using the shown contents configuration, including the position entries for hidden files, then toggle hidden files with Command+Shift+. Check how position items affect file and link coordinates and how hidden-file visibility changes are handled. Done means hidden entries no longer shift visible icons or create layout confusion.

Written by the indexing model from the issue text.

Description

{
  "title": "Test Application",
  "icon": "test-app.icns",
  "background": "test-background.png",
  "contents": [
    { "x": 448, "y": 344, "type": "link", "path": "/Applications" },
    { "x": 192, "y": 344, "type": "file", "path": "/Applications/TestApp.app" },
    { "x": 5000, "y": 0, "type": "position", "path": ".VolumeIcon.icns" },
    { "x": 5000, "y": 0, "type": "position", "path": ".background" },
    { "x": 5000, "y": 0, "type": "position", "path": ".DS_Store"}
  ]
}

If contents contains items with "type": "position"

  1. Will affect the x and y values in "type": "file" and "type": "link".
  2. When the user uses the shortcut keys command + shift + . to show/hide files, it will cause layout confusion. (If it doesn’t happen again, you can exit dmg and reopen it)
Dominant language
JavaScript
Stars
1.7k
Forks
158
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from LinusU/node-appdmg

All issues in LinusU/node-appdmg

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.