setting 'icon' to an existing iconfile results in 'TypeError'

Open
#186 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
3/5
Estimated time
1-2 days
Newbie friendliness
35/100
Issue type
Bug
Clarity
Needs clarification
Activity status
Stale
Tech stack
javascript, node.js
Domain
tooling

Research direction

Reproduce the failure with the icon property on Node v10.17.0, then trace the error through gulp-appdmg/index.js, appdmg/lib/pipeline.js, and nested-error-stacks/index.js. Done means setting icon no longer produces the reported TypeError, whether the referenced icon file exists or not.

Written by the indexing model from the issue text.

Description

on node v10.17.0:

TypeError: Cannot read property 'call' of undefined
    at CpFileError.get (/somepath/node_modules/nested-error-stacks/index.js:22:52)
    at /somepath/node_modules/gulp-util/lib/PluginError.js:45:35
    at Array.forEach (<anonymous>)
    at new PluginError (/somepath/node_modules/gulp-util/lib/PluginError.js:44:8)
    at EventEmitter.<anonymous> (/somepath/node_modules/gulp-appdmg/index.js:20:26)
    at EventEmitter.emit (events.js:198:13)
    at EventEmitter.emit (domain.js:448:20)
    at /somepath/node_modules/appdmg/lib/pipeline.js:102:10
    at /somepath/node_modules/appdmg/lib/pipeline.js:29:9
    at Pipeline.runRemainingCleanups (/somepath/node_modules/appdmg/lib/pipeline.js:74:45)

does not matter wether the file exists or not - only removing the property helps.

thanks for checking

Dominant language
JavaScript
Stars
1.7k
Forks
158
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from LinusU/node-appdmg

All issues in LinusU/node-appdmg

Similar issues

More JavaScript issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.