Lightning-AI/pytorch-lightning

Support skipping the first iteration time in process bar

Open

#19,357 opened on Jan 28, 2024

View on GitHub
 (1 comment) (1 reaction) (0 assignees)Python (26,687 stars) (3,233 forks)batch import
featurehelp wantedprogress bar: tqdmtorch.compile

Description

Description & Motivation

Because the first iteration time is incorrect (model initialization and torch.compile when first interation)

Pitch

No response

Alternatives

No response

Additional context

No response

cc @borda @awaelchli @carmocca

Contributor guide

Tech stack
python
Domain
machine learning
Issue type
feature
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
PythonPyTorch Lightning basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
50
Research direction
Look at the progress bar implementation in pytorch lightning, likely in pytorch lightning/callbacks/progress bar.py. Identify where the iteration time is computed and displayed. The first iteration time is incorrect due to model initialization and torch.compile overhead. Consider adding an option to skip the first iteration time or adjust its calculation. Check if there are any related comments or existing patterns in the codebase.