Lightning-AI/lightning-thunder

Make `numel` a method of TensorProxy not a property attribute

Open

#925 opened on Aug 5, 2024

View on GitHub
 (2 comments) (0 reactions) (0 assignees)Python (114 forks)github user discovery
good first issue

Repository metrics

Stars
 (1,460 stars)
PR merge metrics
 (PR metrics pending)

Description

🐛 Bug

PyTorch uses tensor.numel() while Thunder's TensorProxy and in the codebase it's used as a property tensor.numel. The property attribute makes more sense, but it conflicts with setting PyTorch as the default language context (https://github.com/Lightning-AI/lightning-thunder/pull/924).

Related PR: https://github.com/Lightning-AI/lightning-thunder/pull/278

We should decide what to do with numel and how to avoid the discrepancy with PyTorch.

Contributor guide

Research direction
Investigate the usage of `numel` in the lightning thunder codebase, particularly in TensorProxy and its subclasses. Determine if changing from property to method is feasible and consistent with PyTorch API. Review linked PR #278 and #924 for context.
Tech stack
pythonpytorch
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PythonPyTorch
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75