Lichess4545/heltour

interpret lichess reply to sending dms correctly

Open

#698 opened on Jul 2, 2025

View on GitHub
 (0 comments) (0 reactions) (1 assignee)Python (12 forks)auto 404
P3 - lowbuggood first issue

Repository metrics

Stars
 (5 stars)
PR merge metrics
 (PR metrics pending)

Description

in this line: https://github.com/Lichess4545/heltour/blob/91ce688af08eb5f0d1cb9f2ad92bb0e19e0f2795/heltour/tournament/lichessapi.py#L127-L128 we check whether the lichess reply is "ok". however, the actual lichess reply for a successful message is not simply "ok", but the json '{"ok": true}'. this leads to a lot of error messages Error sending mail: {"ok":true} in our log.

Contributor guide

Research direction
Look at the Lichess API documentation for the messaging endpoint to confirm the response format. Then modify the condition in tournmanent/lichessapi.py lines 127-128 to parse the JSON response and check if the 'ok' field is true.
Tech stack
python
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
75