Lichess4545/heltour

if team slack channels are not set, in team_spam we still claim to have sent team messages

Open

#659 opened on Jun 3, 2025

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (12 forks)auto 404
P3 - low[Team]buggood first issuepython

Repository metrics

Stars
 (5 stars)
PR merge metrics
 (PR metrics pending)

Description

in team_spam we reasonably only (try to) send team messages to teams that have a channel set. but then we proceed to claim that we sent messages to all the teams. we should probably keep track of how many teams we actually tried to send messages to. and if it is not all teams, mention how many we skipped, possibly adding which ones.

this is minor, since automatic team creation should practically ensure that teams mostly have slack channels set. but considering that automatic team creation was not working for years – this would have been a nice place to detect teams without channel set.

Contributor guide

Research direction
Examine the team spam function in admin.py. Track how many teams actually have a Slack channel set and adjust the success message to reflect the actual number of messages sent. Optionally, list the teams that were skipped.
Tech stack
pythondjango
Domain
backend
Issue type
Bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
2
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPythonDjango
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
85