Lichess4545/heltour

has_played_20_games should be renamed

Open

#549 opened on Jan 5, 2025

View on GitHub
 (0 comments) (0 reactions) (0 assignees)Python (12 forks)auto 404
P3 - lowgood first issue

Repository metrics

Stars
 (5 stars)
PR merge metrics
 (PR metrics pending)

Description

https://github.com/Lichess4545/heltour/blob/15dce1b2ab6bc21822ed258472396161933c4d41/heltour/tournament/models.py#L1762 has_played_20_games is a name that has been incorrect for 7 or 8 years – nowadays it should be has_established_rating or something similar. this is a very small thing, but i still think it should be renamed. it's confusing if you're not familiar with how rating deviation worked on lichess historically and/or how the league rules changed to reflect this. mostly adding this issue so we don't forget about it.

Contributor guide

Research direction
Find all occurrences of has played 20 games in the codebase and rename them to has established rating. Update both the Python code and any references (e.g., in templates, tests, comments). Run tests to ensure nothing is broken.
Tech stack
python
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
GitPython
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
95