LedgerHQ/ledger-live-desktop

Websocket Proxy passthrough

Open

#1073 opened on Jul 12, 2018

View on GitHub
 (46 comments) (0 reactions) (0 assignees)JavaScript (955 stars) (326 forks)batch import
feature requestgood first issue

Description

Ledger Live Version and Operating System

  • Ledger Live 1.0.1
  • Platform: linux

When the manager is opened, ledger live checks Internet connectivity.

If I have a proxy (configured via environment variables), the program does not detect that connectivity, it shows a red message “Oops, internet seems down” and offers to retry; which never detects it (see attached screenshot ledger-live.proxy-netdown.png).

On my squid3 logs I have messages like this one: “TAG_NONE/400 4062 NONE error:invalid-request - HIER_NONE/- text/html”

If I unset proxy environment variables, then network detection, and the program, works fine.

I could attach application.log if you need it, I’m guessing you won't since I've been able to reproduce it on two different computers (one with debian sid, the other with debian stretch, both updated to date).

Thanks ledger-live proxy-netdown

Contributor guide

Tech stack
javascriptnodejs
Domain
desktopbackend
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
mostly clear
Prerequisites
knowledge of proxy configurationbasic Node.js debugging
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
30
Research direction
The issue describes a failure to detect internet connectivity when using a proxy. The fix likely involves inspecting the network detection code, which may use WebSocket or HTTP requests. Look for the connectivity check function, possibly in the main process of the Electron app, and ensure it respects environment proxy variables (HTTP PROXY, HTTPS PROXY, NO PROXY). The root cause may be that the WebSocket client or HTTP agent is not configured to use the proxy. Check the application's network stack and consider using a library like 'global agent' or configuring the agent manually. The issue has not been addressed, so first confirm if the problem is still reproducible in the current codebase.