Type error when loading application
Nobody has claimed this yet.
Assessment
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Newbie friendliness
- 45/100
Research direction
Start in hexLoader.py at the Python 3 compatibility change referenced in the issue, then trace the encryptAES call from loadApp.py. Reproduce the failure with Python 2.7 and verify that loading an application works there while retaining Python 3 compatibility.
Written by the indexing model from the issue text.
Description
Information
- Python 2.7.6
- ledgerblue 1.1.16
Description
When loading an application on the ledger, I am seeing the following error:
Traceback (most recent call last):
File "/usr/lib/python2.7/runpy.py", line 162, in _run_module_as_main
"__main__", fname, loader, pkg_name)
File "/usr/lib/python2.7/runpy.py", line 72, in _run_code
exec code in run_globals
File "/usr/local/lib/python2.7/dist-packages/ledgerblue/loadApp.py", line 174, in <module>
loader.createApp(args.appFlags, appLength, args.appName, icon, path, None, None, args.appVersion)
File "/usr/local/lib/python2.7/dist-packages/ledgerblue/hexLoader.py", line 163, in createApp
data = self.encryptAES(data)
File "/usr/local/lib/python2.7/dist-packages/ledgerblue/hexLoader.py", line 95, in encryptAES
encryptedData = cipher.encrypt(paddedData)
File "/usr/lib/python2.7/dist-packages/Crypto/Cipher/blockalgo.py", line 244, in encrypt
return self._cipher.encrypt(plaintext)
TypeError: argument must be string or read-only buffer, not bytearray
make: *** [load] Error 1
This appears to be due to the change to hexLoader.py here https://github.com/LedgerHQ/blue-loader-python/commit/ed1e3a4dac54bbc3f0e6d0fa539199c889f92b6c for Python 3 compatibility, which unfortunately does not with python 2.7.x.
Version 0.1.15 works correctly and as intended.
- Dominant language
- Python
- Stars
- 125
- Forks
- 75
- PR merge metrics
- No merged PRs in 30d
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
More from LedgerHQ/blue-loader-python
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
LedgerHQ/blue-loader-python#130 · 1 comment ·
-
Difficulty 4/5 3-5 days Newbie friendliness 45/100
LedgerHQ/blue-loader-python#111 ·
-
Difficulty 4/5 3-5 days Newbie friendliness 30/100
LedgerHQ/blue-loader-python#98 · 3 comments ·
-
Difficulty 3/5 1-2 days Newbie friendliness 35/100
LedgerHQ/blue-loader-python#96 · 4 comments · 3 reactions ·
-
Difficulty 3/5 1-2 days Newbie friendliness 25/100
LedgerHQ/blue-loader-python#83 · 1 comment ·
All issues in LedgerHQ/blue-loader-python
Similar issues
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
syfoud/Simulated_Scepter#172 ·
-
A cancelled tests run makes the coverage comment workflow fail and reports it as a red check on main Openarea: ci bug perceived difficulty: 3
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
Nitjsefnie-Harness-Commons/daedalus#921 · 1 comment ·
-
Difficulty 2/5 1-3 hours Newbie friendliness 86/100
EleutherAI/lm-evaluation-harness#4207 ·
-
Difficulty 1/5 Under an hour Newbie friendliness 92/100
-
Difficulty 2/5 1-3 hours Newbie friendliness 78/100
ClickHouse/clickhouse-connect#1057 ·