consider switching to pycryptodome

Open
#22 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
25/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Stale
Tech stack
python
Domain
tooling

Research direction

Start by locating where this Python project declares its pycrypto dependency and how installation is tested. Confirm whether pycryptodome can replace it on macOS, then verify that the loader installs and works without the pycrypto dependency.

Written by the indexing model from the issue text.

Description

So for reasons I haven't figured out yet, I am unable to install pycrypto 2.6.1 (which ledgerblue depends on) on Mac OS X 10.13.2 due to being unable to find gmp.h despite it being installed with Homebrew. Its likely because Homebrew changed up paths (I think I recall pkg-config changing behaviors a while back). But in trying to find the issue I went to pycrypto's GitHub and stumbled across https://github.com/dlitz/pycrypto/issues/238 which seems to imply that pycryptodome is the continuation of pycrypto which is very clearly dead. I mention this issue for you to consider switching since I was at least able to install it.

Dominant language
Python
Stars
125
Forks
75
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from LedgerHQ/blue-loader-python

All issues in LedgerHQ/blue-loader-python

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.