LearningCircuit/local-deep-research

tests: import-validation docstring cites brave default_params.time_period, which never gained an options list

Open

#5,676 opened on Aug 22, 2026

View on GitHubContributor guide
 (1 comment) (0 reactions) (0 assignees)Python (776 forks)auto 404
documentationgood first issuepriority: lowtests

Repository metrics

Stars
 (8,787 stars)
PR merge metrics
 (Avg merge 2d 11h) (263 merged PRs in 30d)

Description

Follow-up to #5597 (fixes #5589).

The module docstring of tests/settings/test_import_settings_validation.py:6 cites the motivating example as:

a free-text search.engine.web.brave.default_params.time_period value from before the field gained an options list

But that key has not gained an options list. In the current defaults:

key ui_element options
search.engine.web.brave.default_params.time_period text null
search.engine.web.serpapi.default_params.time_period text null
search.engine.web.serper.default_params.time_period select day / week / month / year / null
search.engine.web.tavily.default_params.time_period select d / w / m / y

Impact: a maintainer tracing the regression to the cited key finds brave's time_period is still free-text, which undercuts the documented motivation and sends reproduction effort to the wrong setting.

Scope: docstring only. The tests themselves correctly exercise search.time_period and the validation logic is unaffected.

Suggested fix: point the example at a key that actually carries an options list — search.engine.web.serper.default_params.time_period or the tavily equivalent — or drop the engine qualifier so the example matches the changelog's generic default_params.time_period phrasing.

Contributor guide

Research direction
Locate the module docstring in tests/settings/test import settings validation.py, verify which search engine time period settings currently have an options list, and update the example to reference one of those keys (e.g., search.engine.web.serper.default params.time period) or use the generic default params.time period phrasing.
Tech stack
python
Domain
backendtesting
Issue type
Documentation
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
1
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
Under 1 hour
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
Git
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
95