Leantime/leantime

Move all repo calls from controllers to services

Open

#1,532 opened on Mar 31, 2023

View on GitHub
 (1 comment) (0 reactions) (0 assignees)PHP (957 forks)batch import
Help Wantedgood-first-issue

Repository metrics

Stars
 (9,827 stars)
PR merge metrics
 (Avg merge 12h 22m) (61 merged PRs in 30d)

Description

The controllers should not be calling the repos directly. Instead they should call a service method. The service layer should be the layer calling the repo.

As such the task is to go through all controllers and update repository calls to be service calls. If the method does not exist in the service a wrapper service method should be created.

Contributor guide

Research direction
Identify all controller files in the project. For each controller method that directly calls a repository (e.g., `$this >repo >method()`), locate the corresponding service class (if any). If the service already has a method that wraps the repo call, replace the direct repo call with the service method. If no such service method exists, create a new method in the appropriate service that delegates to the repository, then update the controller to use the service. Ensure that the service is injected into the controller. Test that the application still works after changes.
Tech stack
php
Domain
backend
Issue type
Refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
Active
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
Clear
Prerequisites
PHPGit
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70