Leantime/leantime

Move all repo calls from controllers to services

Open

#1532 opened on Mar 31, 2023

View on GitHub
 (0 comments) (0 reactions) (0 assignees)PHP (9,827 stars) (957 forks)batch import
Help Wantedgood-first-issue

Description

The controllers should not be calling the repos directly. Instead they should call a service method. The service layer should be the layer calling the repo.

As such the task is to go through all controllers and update repository calls to be service calls. If the method does not exist in the service a wrapper service method should be created.

Contributor guide

Tech stack
None
Domain
backend
Issue type
refactor
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-2 days
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
stale
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
PHPMVC architecture
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
60
Research direction
Go through all controller files in the repository (likely in /app/Controllers) and identify direct repository calls. For each such call, check if a corresponding service method exists; if not, create one in the appropriate service class. Ensure that the service layer calls the repo instead.