async_websocket not present since 0.3.5

Open
#231 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
35/100
Issue type
Bug
Clarity
Mostly clear
Activity status
Stale
Tech stack
python
Domain
build-system

Research direction

Read setup.py and compare its version check with the contents of the 0.3.5 and 0.4.2 releases. Reproduce the two pip installs shown in the issue, then verify that the packaged 0.4.2 installation includes async_websocket.py while preserving the other package files.

Written by the indexing model from the issue text.

Description

I don't get async_websocket.py installed in releases after 0.3.5.

$ pip install 'ws4py' -U
...
Successfully installed ws4py-0.4.2
(venv) $ ls venv/lib/python3.5/site-packages/ws4py/
client     exc.py      __init__.py  messaging.py  server        utf8validator.py
compat.py  framing.py  manager.py   __pycache__   streaming.py  websocket.py

$ pip install 'ws4py<0.4.0'
...
Successfully installed ws4py-0.3.5
(venv) $ ls venv/lib/python3.5/site-packages/ws4py/
async_websocket.py  compat.py  framing.py   manager.py    __pycache__  streaming.py      websocket.py
client              exc.py     __init__.py  messaging.py  server       utf8validator.py

It looks like older releases did wheels, and newer ones release as source. The version check in setup.py seems to be failing.

Dominant language
Python
Stars
1.1k
Forks
285
PR merge metrics
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Lawouach/WebSocket-for-Python

All issues in Lawouach/WebSocket-for-Python

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.