Questions about order modification

Open
#26 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
4/5
Estimated time
3-5 days
Newbie friendliness
35/100
Issue type
Refactor
Clarity
Needs clarification
Activity status
Quiet
Tech stack
java
Domain
backend

Research direction

Start by reading the Order class in the core and the change order interface mentioned in the issue. Determine whether changing the side is intended for this matching engine and, if not, define the required design change and its completion criteria. The issue is currently a question and names no tests.

Written by the indexing model from the issue text.

Description

Hi Laffini. When examining the Order class code in the core, I noticed that the side attribute was not marked as final. Upon further investigation, I found that the change order interface provides the ability to modify the side. However, generally speaking, exchanges do not allow modifications to the side. Therefore, I am somewhat puzzled about this. @Laffini

Dominant language
Java
Stars
23
Forks
15
No merged PRs in 30d

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from Laffini/Java-Matching-Engine-Core

All issues in Laffini/Java-Matching-Engine-Core

Similar issues

More Java issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.