Tests: source_importer: Add a real test for batching alerts.

Open Beginner friendly
#96 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Assessment

Difficulty
2/5
Estimated time
1-3 hours
Newbie friendliness
76/100
Issue type
Feature
Clarity
Mostly clear
Activity status
Active
Tech stack
python
Domain
testing-qa

Research direction

Start with tests/services/test_sourceimporter.py, especially messy_import_30days_batched and test_import_30days_batched, then inspect the source_importer batching path they exercise. Add test data that produces a nonzero number of objects and verify that alert batching is actually covered; run the focused source importer tests to confirm they exercise the intended behavior.

Written by the indexing model from the issue text.

Description

The current tests functions are

tests/services/test_sourceimporter.py::messy_import_30days_batched
tests/services/test_sourceimporter.py::test_import_30days_batched

But they are semi-trivial because the number of objects is 0 and may not really test the batching code in source_importer

Dominant language
Python
Stars
3
Forks
6
Avg merge
6d 24m
Merged PRs (30d)
2

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

More from LSSTDESC/FASTDB

All issues in LSSTDESC/FASTDB

Similar issues

More Python issues

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.