LMMS/lmms

Piano roll pitch bend doesn't cause gui update

Open

#7,675 opened on Feb 1, 2025

View on GitHub
 (0 comments) (0 reactions) (0 assignees)C++ (7,132 stars) (961 forks)batch import
buggood first issuegui

Description

System Information

Linux Mint x86_64 Cinnamon

LMMS Version(s)

nightly

Most Recent Working Version

No response

Bug Summary

In the piano roll, when the pitch bending feature is used on a note, if an automation node is updated via double clicking, the piano roll window will not update and the pitch bending line will stay the same until the cursor hovers over it.

Expected Behaviour

The piano roll updates when the automation node changes value.

Steps To Reproduce

Open a new project, create and open a midi clip, place a note and use the pitch bending tool on it. Create 2 automation nodes in the automation editor and double click one of them to change it's value. When the value is changed the automation editor will update, but the piano roll will not show the updated pitch bending line.

Logs

Screenshots / Minimum Reproducible Project

No response

Please search the issue tracker for existing bug reports before submitting your own.

  • I have searched all existing issues and confirmed that this is not a duplicate.

Contributor guide

Tech stack
cpp
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
1-3 hours
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C++Qt basics
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
70
Research direction
Investigate the piano roll's pitch bend rendering code, likely in the PianoRoll class. When an automation node value is changed, the automation editor updates but the piano roll does not. Ensure that after modifying the automation node, the piano roll's widget is triggered to repaint its pitch bend line. Look for existing update/repaint calls in similar scenarios and apply to this case.
Piano roll pitch bend doesn't cause gui update · LMMS/lmms#7675 | Good First Issue