LMMS/lmms

MIDI auto detect always turned on

Open

#1813 opened on Mar 3, 2015

View on GitHub
 (1 comment) (0 reactions) (0 assignees)C++ (7,132 stars) (961 forks)batch import
enhancementgood first issue

Description

If you connect a control to a MIDI controller and then select "edit connection" again, automatic detection is turned on. The problems with this approach:

  • A stray CC could change the connection to another device, channel and CC.
  • Just opening the dialog will enable the selected channel/CC combo on all devices.
  • There's no way to see which device the control is listening to.

My suggestion is to have automatic detection turned on only if the control isn't already connected.

Contributor guide

Tech stack
cpp
Domain
desktop
Issue type
bug
DifficultyEstimated implementation difficulty for a new contributor, from 1 for very small changes to 5 for expert-level work.
3
Estimated timeA rough time range for an experienced contributor to investigate, implement, test, and prepare a pull request.
half day
Activity statusHow available the issue appears right now: fresh, active, stale, blocked, or waiting on maintainer input.
fresh
ClarityHow clearly the issue explains the expected change, acceptance criteria, and next step.
clear
Prerequisites
C++Qt framework
Newbie friendlinessA 1-100 score estimating how approachable this issue is for first-time contributors.
40
Research direction
Look at the MIDI connection dialog code in LMMS, likely under src/gui/ or src/midi/. The issue describes that automatic detection is always enabled on edit. Check the implementation of the dialog and the logic for toggling auto detection when a connection is already established. The comment history may provide additional context.